-
Notifications
You must be signed in to change notification settings - Fork 148
Support Python 3.14 #1661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Support Python 3.14 #1661
Conversation
|
OK, we are already compatible and just need to wait for numba's next release numba/numba#9957 |
320d478 to
6406529
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1661 +/- ##
==========================================
+ Coverage 81.56% 81.58% +0.01%
==========================================
Files 242 240 -2
Lines 53819 53593 -226
Branches 9485 9454 -31
==========================================
- Hits 43899 43723 -176
+ Misses 7431 7394 -37
+ Partials 2489 2476 -13 🚀 New features to boost your workflow:
|
|
Thanks @Armavica for testing on the beta release of Numba and communicating the success on their Discourse! |
|
Luckily PyTensor was already compatible with Python 3.14. We just had to change the upper bound. So maybe it'd be better to write something like the following for the PR title?
|
I did have to adapt two tests but that's a better title indeed, thank you |
|
Numba is optional, so we can go ahead before their release |
So, without upgrading the CI to 3.14? |
Just not the numba CI |
|
Looks like everything is working? The jax failing tests are probably because tfp isn't yet compatbile with 3.14, we can skip those for now |
Yes but it's still an rc1 for numba |
|
I think we can release already. Perhaps test numba on rc for python 3.14 and keep last official release on python 3.11? |
Description
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pytensor--1661.org.readthedocs.build/en/1661/